ntuple(Val(N)) -> tuplen

cossio · May 11, 2020 · 6702eb8 · 6702eb8 · cossio · May 11, 2020
1 parent 1e6e20d
commit 6702eb8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/util.jl b/src/util.jl
@@ -14,7 +14,7 @@ end
 argmax of `A` over its first `N` dimensions and drops them. By default `N = 1`.
 """
 function argmaxdropfirst(A::AbstractArray, ::Val{N} = Val(1)) where {N}
-	dims = ntuple(Val(N))
+	dims = tuplen(Val(N))
 	argmaxdrop(A; dims=dims)
 end
 
@@ -35,8 +35,8 @@ function columns(A::AbstractArray)
 end
 
 """
-	ntuple(Val(N))
+	tuplen(Val(N))
 
 Constructs the tuple `(1, 2, ..., N)`.
 """
-@generated Base.ntuple(::Val{N}) where {N} = ntuple(identity, Val(N))
+@generated tuplen(::Val{N}) where {N} = ntuple(identity, Val(N))
diff --git a/test/util.jl b/test/util.jl
@@ -1,5 +1,5 @@
 using OneHot, Test, Random
-using OneHot: argmaxdrop, argmaxdropfirst
+using OneHot: argmaxdrop, argmaxdropfirst, tuplen
 
 @testset "argmaxdrop" begin
 	@inferred argmaxdrop(randn(3,2,4); dims=2)
@@ -16,3 +16,8 @@ end
 	i = argmaxdropfirst(A)
 	@test A[i] == [3, 4]
 end
+
+@testset "tuplen" begin
+    @inferred tuplen(Val(5))
+    @test tuplen(Val(5)) == (1,2,3,4,5)
+end