js: Update mocha 7 => 9, drop Node.js v8 support
#901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us update transitive dependency on ansi-regex to fix a potential security vulnerability^W^W^W^W^W stop npm audit whining. This also updates all sorts of other stuff, but I can't do anything about JS ecosystem being braindead, sorry.
Node.js v8 has been EOL since 2020, we only keep testing for it because it did not require maintenance on our part. Well, now our transitive development dependencies require at least Node.js v10, so that's our new minimum supported version then. JsThemis and WasmThemis have a chance to be still working with older Node.js (even before v8), but we don't test that now.
ilammy
added
compatibility
vixentael
approved these changes
Feb 7, 2022
ahha. bye-bye Nodejs v8 ✋ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'd be laughing, but there's more! Dependabot decided to remind me about CVE-2021-3807 which got fixed in October.
Updating
mochalets us update transitive dependency onansi-regextofix a potential security vulnerabilitystop npm audit whining. This also updates all sorts of other stuff, but I can't do anything about JS ecosystem being braindead, sorry. (Though, I'm surprised that jumping over a major version did not break anything that much.)One thing that did break is support for Node.js v8 for running tests. Node.js v8 has been EOL since 2020, we only keep testing for it because it did not require maintenance on our part. Well, now our transitive development dependencies require at least Node.js v10, so that's our new minimum supported version then.
JsThemis and WasmThemis have a chance to be still working with older Node.js (even before v8), but we don't test that now.
Checklist