Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect over https #99

Merged
merged 4 commits into from
Mar 12, 2024
Merged

fix: connect over https #99

merged 4 commits into from
Mar 12, 2024

Conversation

JulianToledano
Copy link
Contributor

Closes:
#97

This PR validates the comet provided endpoint.

Copy link

coderabbitai bot commented Mar 8, 2024

Walkthrough

The recent changes involve enhancing URL validation and manipulation within the configuration management. A new approach using the urlx package has been implemented to parse and validate URLs, ensuring they adhere to correct schemes and ports. This includes the validation of the TendermintRPC URL. Additionally, constants have been introduced for HTTP, HTTPS, and TCP to facilitate URL handling. The updates are complemented by a test suite in config_test.go to verify URL normalization and validation across various formats.

Changes

Files Changes
config.go Introduced URL validation using urlx package; added constants for HTTP, HTTPS, TCP; validated TendermintRPC URL.
config_test.go Added TestConfig_validateUrl to validate and normalize URLs; included test cases for various URL formats.
CHANGELOG.md Added bug fix enabling Rosetta to connect to cometBFT over https; improved LegacyMsg.GetSigners() with codec.GetMsgV1Signers.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@JulianToledano JulianToledano linked an issue Mar 8, 2024 that may be closed by this pull request

This comment has been minimized.

Copy link
Contributor

@lucaslopezf lucaslopezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments!

config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@lucaslopezf lucaslopezf self-requested a review March 11, 2024 17:46
@JulianToledano JulianToledano merged commit 8801327 into main Mar 12, 2024
11 checks passed
@JulianToledano JulianToledano deleted the julian/97 branch March 12, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: can't connect to a node over https
2 participants