fix: fix duplicate processing of begin and end block txs

[hacheigriega]

Fixing the problem where begin block and end block events are processed twice.

[coderabbitai]

Walkthrough

The recent update involves merging two separate transactions, beginBlockTx and endBlockTx, into a single transaction named beginEndBlocksTx. This change simplifies the transaction processing framework by consolidating the initiation and conclusion of blocks into one unified operation.

Changes

File Path	Changes Summary
client_online.go	Merged beginBlockTx and endBlockTx into beginEndBlocksTx.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 92c741d and 792cb34.

Files selected for processing (1)

• client_online.go (2 hunks)

Additional comments not posted (1)

client_online.go (1)

Line range hint 512-533: Consolidation of begin and end block transactions into a single transaction.

This change simplifies the transaction processing logic and potentially reduces redundancy. Ensure that all dependent systems and tests are updated to handle this new transaction format.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[JulianToledano]

Hey @hacheigriega thanks for the PR. I've just checked it and you are right. BeginBlock and EndBlock events are duplicated right now.

However, it seems that the needed change is to update blockTxs to parse comets 0.38.x ResultBlockResults correctly.

You can follow the fix in #121