Fix failing conformance tests and broken ibctest interface
#866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
requested review from
jackzampolin,
boojamya and
mark-rushakoff
as code owners
mark-rushakoff
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 0cb93a6 got merged on Friday it broke the relayer interface implementation in the
ibctestdirectory which caused compilation errors. Fixing this issue revealed another problem around dependencies since we were essentially importing two different versions of the Cosmos SDK and ibc-go.This PR bumps dependencies and fixes the
ibctestpackage so that conformance tests should pass in the relayers CI