CLI - channel handshakes #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agouin
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
mark-rushakoff
approved these changes
Jul 13, 2022
| } | ||
| if logLine.Aux != nil { | ||
| t.Log(logLine.Aux) | ||
| fmt.Print(logLine.Aux) |
There was a problem hiding this comment.
Functions associated with a particular test should log to that test rather than print to stdout. Was this change intentionally committed?
There was a problem hiding this comment.
Ah yes, meant to make a separate PR for this. the logLine.Stream and Aux is formatted for stdout. Using fmt.Print makes it print the same way a docker build would. For comparison:
t.Log:
fmt.Print:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
PathProcessorfor channel handshakes, both automatically when channel handshake messages are detected on the relevant connections and also for the CLI channel creation.After digging through the existing channel handshake code, the configuration never seems to be modified even in cases when returning
modified: true, so I do not think a channel message subscriber will be necessary as it was for the connection handshakes.