Usercase extension with 'rly tx transfer' #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related issue: #804 description: When sending a transaction with rly tx trnsfer, relayer must verify the channel exists based off the path metadata's "src" and "dst" chain. Signed-off-by: hwangjae lee <[email protected]>
meetrick
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
boojamya
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Instead of duplicating that code. Maybe do something like this?
var pathConnectionID string
if src.Chainid == path.Src.ChainID {
pathConnectionID = path.Src.ConnectionID
} else if src.Chainid == path.Dst.ChainID {
pathConnectionID = path.Dst.ConnectionID
} else {
return fmt.Errorf("no path configured using chain-id: %s", src.Chainid)
}
And then in that QueryConnectionChannels function, pass pathConnectionID instead of path.Src.ConnectionID
|
I will check and test, thanks |
Removed duplicate line. Optimize code sequence. Signed-off-by: hwangjae lee <[email protected]>
boojamya
reviewed
Jun 23, 2022
srcChainID is removed. Add src.ChainID(). Signed-off-by: Hwangjae lee <[email protected]>
|
New commit is updated. |
boojamya
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue:
#804
description:
When sending a transaction with rly tx trnsfer, relayer must verify the
channel exists based off the path metadata's "src" and "dst" chain.
Signed-off-by: hwangjae lee [email protected]