Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more meaningful value for the size of the buffered channel #769

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Use a more meaningful value for the size of the buffered channel #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions relayer/strategies.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ func StartRelayer(ctx context.Context, log *zap.Logger, src, dst *Chain, filter
func relayerMainLoop(ctx context.Context, log *zap.Logger, src, dst *Chain, filter ChannelFilter, maxTxSize, maxMsgLength uint64, errCh chan<- error) {
defer close(errCh)

channels := make(chan *ActiveChannel, 10)

// Query the list of channels on the src connection.
srcChannels, err := queryChannelsOnConnection(ctx, src)
if err != nil {
Expand All @@ -45,6 +43,8 @@ func relayerMainLoop(ctx context.Context, log *zap.Logger, src, dst *Chain, filt
return
}

channels := make(chan *ActiveChannel, len(srcChannels))

// Apply the channel filter rule (i.e. build allowlist, denylist or relay on all channels available),
// then filter out only the channels in the OPEN state.
srcChannels = applyChannelFilterRule(filter, srcChannels)
Expand Down