Update cosmwasm bash test scripts and bump cosmwasm version #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
requested review from
jackzampolin,
boojamya and
mark-rushakoff
as code owners
boojamya
approved these changes
Apr 13, 2022
boojamya
reviewed
Apr 13, 2022
configs/wasmd/chains/ibc-1.json
Outdated
| "value": { | ||
| "key": "testkey", | ||
| "chain-id": "ibc-1", | ||
| "rpc-addr": "http://localhost:26657", |
There was a problem hiding this comment.
That's the same rpc as ibc-0
There was a problem hiding this comment.
You're right. When I updated the scripts I didn't update dev-env to use two-chainz-wasmd so it ran the scripts for the cosmos tests 🤦♂️
There was a problem hiding this comment.
Pushing a fix for this rn. Going to just include a fix for rly tx transfer too since it's short.
boojamya
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the configs to the correct format, bumped to most recent release of cosmwasmd, and removed old relayer light client commands.
Edit: didn't point the
dev-envscript to the right scripts for starting up wasmd nodes and upon correcting it there were errors due torly tx transferinvoking the global singleton in the SDK and causing bech32 errors.Including a fix for that here as well. I don't see any reason why we can't just use the string since the call to
SendTransferMsg()expects a string anyways.Closes #674