Pass explicit logger to relayer package functions #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-rushakoff
requested review from
jackzampolin,
jtieri and
boojamya
as code owners
mark-rushakoff
force-pushed
the
refactor/relay-package-logging
branch
from
0e447e1 to
7813657
Compare
Instead of relying on the logger associated with a chain, accept a logger specifically for use in the package-level function. By convention, ctx is always the first parameter, and then log. Passing the logger separately also allows more flexibility in the parameter types to these functions, which will simplify adding new tests shortly.
mark-rushakoff
force-pushed
the
refactor/relay-package-logging
branch
from
7813657 to
cc1630e
Compare
jtieri
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the logger associated with a chain, accept a
logger specifically for use in the package-level function.
By convention, ctx is always the first parameter, and then log.
Passing the logger separately also allows more flexibility in the
parameter types to these functions, which will simplify adding new tests
shortly.