Replace time.Sleep calls with time.After and context check #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-rushakoff
requested review from
jackzampolin,
jtieri and
boojamya
as code owners
This way, if a user sends SIGINT during a point when we were previously sleeping, this should begin cancellation immediately instead of waiting for the sleep to complete first.
mark-rushakoff
force-pushed
the
refactor/context-sleep
branch
from
cda0ab4 to
6ba6197
Compare
jtieri
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, if a user sends SIGINT during a point when we were previously
sleeping, this should begin cancellation immediately instead of waiting
for the sleep to complete first.