Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary linker flag in goreleaser.yaml #638

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

jtieri
Copy link
Member

@jtieri jtieri commented Mar 29, 2022

We no longer need the linker flag for the SDK version since we are retrieving that at runtime. I'm fairly certain this is causing the goreleaser job to fail

Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense if it was expanding to an empty string.

@jtieri jtieri merged commit 3728c09 into main Mar 29, 2022
@jtieri jtieri deleted the justin/remove-linker-flag branch March 29, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants