bump lens dep & wire up --coin-type flag
#630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
requested review from
jackzampolin,
boojamya and
mark-rushakoff
as code owners
There was a problem hiding this comment.
This has a bit of overlap with a branch I didn't push to a PR on Friday. Do you want to compare the tree at 18f8146 and see if there were any other differences besides the key output adapter and errgroup context usage?
Went through that branch and I believe anything missing should be added in here now as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
KeyProviderimplementation inlensutilizes thecointypeparameter in key derivation, we need to update our version oflensso that we can also consume the--coin-typeflag in the relayers cmds for adding and restoring keys.Function parameters on various methods in the
providerpackage needed to be updated so that we can pass in a context to them.Closes #588
Closes #596