-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull chain data from Chain Registry, Add paths new cmd, & Improve CLI experience/quick-start guide #557
Conversation
Want to note that I experienced this issue (#562) when adding chains today. |
Interesting, maybe we can increase the rate limit enough to not hit these errors using authenticated requests.
https://github.com/google/go-github#authentication Maybe this is a per user basis though? Managing tokens as a user seems like bad UX so perhaps we do want to clone the repo and traverse the files locally to move from making multiple calls to the GitHub API to only one every time |
Read through some of the docs. It's confusing b/c its different on how you set it up and github user status. I can't imagine I hit the rate limit as and individual user. Without an enterprise account I get 5000 requests per hour. ¯_(ツ)_/¯ So... check this out:
(From: https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting) So I guess it depends on how we implemented the API call... and it could be repo based. I do think pulling the whole chain registry repo down is a good quick fix though. OR pointing to URL specifically. |
* add command to create a new blank path in the config * add retries & cleanup CreateClients * use tagged lens version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love these features.
lens now contains the facilities for fetching chain metadata from the chain-registry.
This PR removes the
fetch
cmd tree from the relayer in favor of using lens for fetching this chain metadata. Users can now specify which chains they want to pull data for inrly chains add [chain names]
e.g.
rly chains add osmosis cosmoshub
Because the chain-registry does not contain the necessary metadata for paths we still need to maintain this data ourselves but instead of using the
fetch
cmd tree users can userly paths fetch
which will pull the paths for every chain they have configured viarly chains add
#564 adds a new command
rly paths new [src-chain-id] [dst-chain-id] [path-name] [flags]
which will generate a new blank path between src and dst in yourconfig.yaml
fileCloses #538