Difftest core: small PR removes some todos #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
requested review from
jtremback,
mpoke,
sainoe and
shaspitz
as code owners
danwt
commented
Jan 10, 2023
| @@ -237,7 +237,6 @@ func (s *CoreSuite) matchState() { | |||
| for j := 0; j < initState.NumValidators; j++ { | |||
| s.Require().Equalf(int64(s.traces.Tokens(j)), s.providerTokens(int64(j)), diagnostic+"P tokens mismatch for val %d", j) | |||
| } | |||
| // TODO: delegations | |||
There was a problem hiding this comment.
Not a good idea/ not worth doing. The method is blackbox and delegations are implementation detail.
More docs/ onboarding material is coming which will explain method and reasoning.
danwt
commented
Jan 10, 2023
| @@ -256,7 +255,6 @@ func (s *CoreSuite) matchState() { | |||
| s.Require().Errorf(err, diagnostic+" power mismatch for val %d, expect 0 (nil), got %d", j, actual) | |||
| } | |||
| } | |||
| // TODO: outstanding downtime | |||
There was a problem hiding this comment.
Not a good idea/ not worth doing. The method is blackbox and delegations are implementation detail.
More docs/ onboarding material is coming which will explain method and reasoning.
danwt
commented
Jan 10, 2023
Comment on lines
-316
to
+318
| // TODO: write assumption that checks that throttle params are appropriate | ||
| // TODO: Write a check to make sure that the slash throttle params are set correctly. | ||
| // The params should be set such that the slash throttle never kicks in and stop a slash. | ||
| // This is because the model assumes that a slash will always be executed, no matter | ||
| // how many. This can be achieve by setting the slash factor to e.g. 1.0 and the refresh | ||
| // period to 1 block. |
There was a problem hiding this comment.
I'll try to get to this but it's very low prio so I enhanced the description.
danwt
commented
Jan 10, 2023
| @@ -7,7 +7,6 @@ import { strict as assert } from 'node:assert'; | |||
| * This model may need updating pending | |||
| * https://github.com/cosmos/ibc/issues/825 (model updated, spec has open PR) | |||
| * https://github.com/cosmos/ibc/issues/796 (model updated, spec awaiting PR) | |||
| * TODO: implement automatic commit hash comparison warning against spec | |||
There was a problem hiding this comment.
Not worth doing/ too much hassle.
mpoke
approved these changes
Jan 10, 2023
danwt
pushed a commit
that referenced
this pull request
Jan 12, 2023
commit 463ec20 Author: Daniel T <[email protected]> Date: Wed Jan 11 18:24:12 2023 +0000 Difftest core: small PR removes some todos (#656) * Removes model TODO * Removes 1 TODO * Removes 1 TODO * Clarify 1 TODO Co-authored-by: Daniel <[email protected]> Co-authored-by: Shawn <[email protected]> commit 35f1e26 Author: Shawn <[email protected]> Date: Wed Jan 11 09:10:44 2023 -0800 Removes depreciated keyring dependency (#657) changes
sainoe
added a commit
that referenced
this pull request
Feb 1, 2023
…658) * Renames init state -> init state var * Renames block seconds -> block interval * Removes one reference to init state var in setup * Adds and inits initState field in core suite * Uses instance of init state on suite in core_test * Removes one hardcoded param in setup * Removes one hardcoded param * Adds test validator creation util * Deletes one todo * Use crypto util in create Validators * Uses b.initState.UnbondingC in consumer genesis * Extract func run some protocol steps * Renames setup util methods * Removes builder build * Renames setup method * Moves link creation call in setup * Simplifies creation of new validators in setup * Replaces some uses of P, C in setup * Removes many uses of P, C * Removes getValidatorPK * Moves param related statements * Moves slash param * Rename method * Squashed refactors commit d1c3ac45289e4e0e0614e4133978f1807401d544 Author: Daniel <[email protected]> Date: Wed Jan 11 09:15:17 2023 +0000 Inlines doStuff commit 5490df90919f11f0d5cc794fa4b7eadc6ba32343 Author: Daniel <[email protected]> Date: Wed Jan 11 09:14:55 2023 +0000 Deletes unnecesssary line commit 8b19fcb42e0f235d129c1b63830c562749142238 Author: Daniel <[email protected]> Date: Wed Jan 11 09:13:51 2023 +0000 Extract consumer genesis commit 4195b858fe5c1cb1c5212a8efbf0cee460cc44a8 Author: Daniel <[email protected]> Date: Wed Jan 11 09:10:53 2023 +0000 Extract createConsumerClientGenesisState commit 08a4d4804926ac029d35937606c17c9a6fe8eb7c Author: Daniel <[email protected]> Date: Wed Jan 11 09:07:52 2023 +0000 Amend: move forgotten line commit c3637354c649c67bf2fb5fca547a01ca5cd5aea9 Author: Daniel <[email protected]> Date: Wed Jan 11 09:07:28 2023 +0000 Extract configureConsumerClientOnProvider commit 236cf1f0f5eac25607f3354521e474c0bfe98596 Author: Daniel <[email protected]> Date: Wed Jan 11 09:06:02 2023 +0000 Move consumer client init on provider commit 04a438dbddd403d069eb9b6fc260c021c0d752d9 Author: Daniel <[email protected]> Date: Wed Jan 11 08:59:11 2023 +0000 Move configureIBCTestingPath commit e977309b4205be6078bf9cde2f48f767928723e6 Author: Daniel <[email protected]> Date: Wed Jan 11 08:58:44 2023 +0000 Extract configureIBCTestingPath commit 4d8d3e83999486dc1c63fa83fc8667dc24c1ca38 Author: Daniel <[email protected]> Date: Tue Jan 10 19:48:07 2023 +0000 Moves channel, connections HS to setup body commit 30d583446e0d70b4ef3d1d5521a60105f0500c35 Author: Daniel <[email protected]> Date: Tue Jan 10 19:47:03 2023 +0000 Inlines ibc handshake commit 0b3d6c4029950e4bc19b871376ae4a0d36d42c87 Author: Daniel <[email protected]> Date: Tue Jan 10 19:45:13 2023 +0000 Inlinen create consumer gen commit 27949cb4f917ac88c0262b95d1c2a85e072e4d42 Author: Daniel <[email protected]> Date: Tue Jan 10 19:44:12 2023 +0000 Extract doStuff *fix commit eed615ecd987497dee9a7b452e9507f7cc97263d Author: Daniel <[email protected]> Date: Tue Jan 10 19:43:24 2023 +0000 Extract doStuff commit ded978c4270c474c878577267690f04bcc5ab19e Author: Daniel <[email protected]> Date: Tue Jan 10 19:41:48 2023 +0000 Extracts 1 method * Style changes * Removes chainID helper * Move method * Removes SendEmptyVSC Squashed commit of the following: commit 21bfdab6d3c98932bf89a36a596a89234c46d83b Author: Daniel <[email protected]> Date: Wed Jan 11 11:31:13 2023 +0000 Gets rid of sendEmpty commit c7564905073427329114e665d4b6f270e7055960 Author: Daniel <[email protected]> Date: Wed Jan 11 09:57:31 2023 +0000 Adds debug session * Style * Extract stuff to remove to isolated file * Moves method * Moves createLink * Extracts BHelper * Squashed commit of the following: commit a42c4c08970189d2ddbf9665b911142071a6e57f Author: Daniel <[email protected]> Date: Wed Jan 11 13:32:55 2023 +0000 Finish offshoot commit d2d4b22b009bb91302a7cdaf3c86f167a1bd973a Author: Daniel <[email protected]> Date: Wed Jan 11 13:29:54 2023 +0000 Deletes unused functions commit 907f791dee9d562e5dbc856494057f2f003ffbf7 Author: Daniel <[email protected]> Date: Wed Jan 11 13:29:34 2023 +0000 Moves extracted to setup commit 7ad303c5f330dbffa811d3fcab16244aa7639727 Author: Daniel <[email protected]> Date: Wed Jan 11 13:26:01 2023 +0000 Finish refactor commit f51297d9c3ce6202ef09a76212cf35e3a780237e Author: Daniel <[email protected]> Date: Wed Jan 11 13:19:40 2023 +0000 Deletes unused code commit e32acc4146c2f12180c17cf78fecc1df519247fa Author: Daniel <[email protected]> Date: Wed Jan 11 13:04:21 2023 +0000 Uses chainUtil directly commit 7ed48fe00c1bf4bf439966fad4d21fd3ef7ebe1d Author: Daniel <[email protected]> Date: Wed Jan 11 12:50:38 2023 +0000 Moves 1 lien commit 0b938bbc7ea3780c7e9b2a885eaa6fb58eaec704 Author: Daniel <[email protected]> Date: Wed Jan 11 12:49:47 2023 +0000 Small ref commit 10d6ada224548e8fb0c3b43418d53a9109215c16 Author: Daniel <[email protected]> Date: Wed Jan 11 12:47:37 2023 +0000 double check all tests commit 49c5c122e17f441a0dd5be77f8be383dc5d0a09c Author: Daniel <[email protected]> Date: Wed Jan 11 12:46:33 2023 +0000 Small ref commit f284a0641118c723c78aaa4670f975ff95a82447 Author: Daniel <[email protected]> Date: Wed Jan 11 12:44:13 2023 +0000 Small inline commit ebcb021cd7eb47f961b03a6ec4e534702f05108b Author: Daniel <[email protected]> Date: Wed Jan 11 12:38:52 2023 +0000 Removes mustBegin commit 036faf330f55fce90ddf3d6bd2091917edc33ee8 Author: Daniel <[email protected]> Date: Wed Jan 11 12:33:08 2023 +0000 Hedge commit ecdc15811185aedca62fb60ce0046eb6cfb62b58 Author: Daniel <[email protected]> Date: Wed Jan 11 12:27:52 2023 +0000 Confirm a further removal commit 46b175c2a1103db2fc787e9267f720a0eb8220d7 Author: Daniel <[email protected]> Date: Wed Jan 11 12:26:07 2023 +0000 Confirm further removal commit cce946d84ee8cd3e4e9b9d4175416611269cb7cc Author: Daniel <[email protected]> Date: Wed Jan 11 12:17:06 2023 +0000 Removes unused code commit 3e3e7322f54a1fee45415dd7807adfe345c70b82 Author: Daniel <[email protected]> Date: Wed Jan 11 12:15:15 2023 +0000 Confirm pass with major removal commit 3798ca67ef5c347d0b0dc4c846e2320e41a1edc5 Author: Daniel <[email protected]> Date: Wed Jan 11 12:01:23 2023 +0000 Prove 0 progression * Small QoL changes * Factor out dynamic endpoint helper * renames createChains * Factors out params setting method * Rename path method * Fix client config line * Method renames * QoL changes * Extract setup test * Squashed commit of the following: commit 463ec20 Author: Daniel T <[email protected]> Date: Wed Jan 11 18:24:12 2023 +0000 Difftest core: small PR removes some todos (#656) * Removes model TODO * Removes 1 TODO * Removes 1 TODO * Clarify 1 TODO Co-authored-by: Daniel <[email protected]> Co-authored-by: Shawn <[email protected]> commit 35f1e26 Author: Shawn <[email protected]> Date: Wed Jan 11 09:10:44 2023 -0800 Removes depreciated keyring dependency (#657) changes * add test * save * improve naming * update naming * update test comments * fix bug * patch for saino/crypto (#673) * Use secpk * Refactor * Bump * bump Co-authored-by: Daniel <[email protected]> * reformat * Update testutil/crypto/crypto.go Co-authored-by: Shawn <[email protected]> * Update x/ccv/provider/keeper/hooks_test.go * builds now * nit * add validator logs * fix cryptolib bug introduced after merging with main --------- Co-authored-by: Daniel <[email protected]> Co-authored-by: Simon Noetzlin <[email protected]> Co-authored-by: Shawn <[email protected]>
ThanhNhann
pushed a commit
to decentrio/interchain-security
that referenced
this pull request
Jan 3, 2024
* Backport commits from main to v3 release branch (cosmos#682) * reorganize channel handshake handler (cosmos#647) * reorganize channel handshake handler split out channel state changes into its own function. * readjust 27-interchain-accounts to not rely on state being set before the application callback * add changelog and migration doc entry * Update modules/core/04-channel/keeper/handshake.go * docs: ICA Overview (cosmos#626) * docs: ica overview * fix: ordering * add spacing * fix: spacing * fix: remove bulletpoints * fix: wording * update go mod for security vulnerabilities (cosmos#655) * update go mod for security vulnerabilities * update package-lock.json * update vue dependency (cosmos#662) * bump glob-parent version in json package (cosmos#663) * build(deps): bump actions/setup-go from 2.1.4 to 2.1.5 (cosmos#656) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.4 to 2.1.5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2.1.4...v2.1.5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <[email protected]> * docs: begin removal of internal "spec" directories (cosmos#634) * begin removal of spec docs within core ibc * remove broken link * Apply suggestions from code review Co-authored-by: Damian Nolan <[email protected]> * remove broken link * remove broken links * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> * Modify `OnChanOpenTry` application callback to perform app version negotitation (cosmos#646) * remove NegotiateAppVersion and AppVersion gRPC (cosmos#643) The NegotiateAppVersion callback has been removed from the IBC Application interface. The gRPC AppVersion has been removed. The app version negoitation will be handled by applications by returning the version in OnChanOpenTry. * Modify `OnChanOpenTry` to return application version (cosmos#650) * modify OnChanOpenTry to return negotiated version modify IBCModule interface function OnChanOpenTry to return the negotiated app version. Tests have not been updated * fix ibc_module_test.go tests * fix tests * Apply suggestions from code review * add handshake test case * add CHANGELOG and migration docs * update documentation * fix broken link * fix broken link (cosmos#664) * chore: update make build-docs, add docs build checker (cosmos#667) * update Makefile, add docs build checker * Update .github/workflows/check-docs.yml Co-authored-by: Marko <[email protected]> Co-authored-by: Marko <[email protected]> * register ICA query server, fix panics in params query cli (cosmos#666) Register the controller and host query servers to a chain. Returns an error upon cli params query failure instead of panicing. * update of roadmap with latest release (cosmos#653) * update of roadmap with latest release and changed the way release versions are encoded * fixed typo Co-authored-by: Carlos Rodriguez <[email protected]> * build(deps): bump actions/checkout from 2.3.1 to 2.4.0 (cosmos#672) Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.1 to 2.4.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2.3.1...v2.4.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * allow ics20 to connect to middleware (cosmos#675) * allow ics20 to connect to middleware Creates ics4Wrapper which allows middleware applications to only implement SendPacket to connect ics20 as an application in its middleware stack * add changelog and migration doc * fix migration doc spelling * fix: register InterchainAccount as x/auth GenesisAccount (cosmos#676) * adding GenesisAccount interface registration for InterchainAccount impl * updating RegisterInterfaces ica godoc * enable mergify for backports (cosmos#678) Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Sean King <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> * fixes evmos tests * cleanup * changelog and cleanup * pr suggestions. bump chainid Co-authored-by: colin axnér <[email protected]> Co-authored-by: Sean King <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes some TODOs, clarifies one
Type of change
Refactor