test: Fix use of hardcoded cosmos... address

[p-offtermatt]

Description

Closes: #N/A

Changes handling of a hardcoded address to be done with fixed prefix

This should fix an issue that was surfaced by consumer chains that run this test, since their bech32 prefix is different

This is to address an issue that was surfaced by a consumer chain when upgrading to ICSv5.1.1

In general, if we want to offer our tests to consumer chains to test against, we cannot hardcode cosmos... addresses (at least in the integration and unit tests, where it seems this will mess things up)

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• Included the correct type prefix in the PR title
• Targeted the correct branch (see PR Targeting)
• Provided a link to the relevant issue or specification
• Reviewed "Files changed" and left comments if necessary
• Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• Confirmed the correct type prefix in the PR title
• Confirmed all author checklist items have been addressed
• Confirmed that this PR does not change production code

Summary by CodeRabbit

• Bug Fixes

  • Improved accuracy of the "IBC Transfer recipient is not the consumer rewards pool address" test case by using a dynamic address instead of a hardcoded one.

• Tests

  • Enhanced test readability and functionality through streamlined setup functions.
  • Ensured consistent passing of the test suite context in test cases for better integration.
  • Introduced a new variable for improved test accuracy in the IBC Transfer middleware scenario.

[p-offtermatt]

Nope, doesn't look like the way to do it actually, closing in favor of #2123

[p-offtermatt]

Reopening, because indeed it does seem like the way to fix the issue. The test failure with #2123 confirmed that on consumer chains, in integration tests the provider chain nonetheless seems to use the consumer bech32 prefix

[coderabbitai]

Walkthrough

Walkthrough

The recent changes streamline the test suite for TestRewardsDistribution and TestIBCTransferMiddleware by modifying the setup function signatures to incorporate a pointer to CCVTestSuite. This enhances access to suite properties and ensures consistent context usage across test cases. Additionally, minor adjustments improve test accuracy, such as dynamically retrieving addresses instead of using hardcoded values, ultimately enhancing clarity and functionality without altering core logic.

Changes

File Path	Change Summary
tests/integration/distribution.go	Updated setup function signatures in TestIBCTransferMiddleware to accept a pointer to CCVTestSuite. Streamlined TestRewardsDistribution for improved readability. Adjusted address retrieval in the IBC transfer test case for accuracy.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.