Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: MsgSetConsumerCommissionRate sets the rate correctly (backport #2110) #2111

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 29, 2024

Description

Added an action in the E2E tests so that we can test that MsgSetConsumerCommissionRate sets the commission rate correctly. For simplicity, we introduce this test in the partial-set-security-opt-in E2E test and we do not test the exact rewards retrieved by each validator.

Tested locally with go run ./tests/e2e/... --tc partial-set-security-opt-in.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

Summary by CodeRabbit

  • New Features

    • Introduced functionality to set and retrieve consumer commission rates for validators.
    • Added structured data types to manage parameters for setting consumer commission rates.
    • Enhanced state management to include consumer commission rates in chain state.
  • Bug Fixes

    • Improved clarity in variable naming for the commission rate setting functionality.
  • Tests

    • Added new test scenarios for managing consumer commission rates, ensuring the robustness of the testing framework.

This is an automatic backport of pull request #2110 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner July 29, 2024 14:37
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Jul 29, 2024
tests/e2e/state.go Dismissed Show dismissed Hide dismissed
@MSalopek MSalopek merged commit 99d6fdf into release/v5.1.x Jul 29, 2024
14 checks passed
@MSalopek MSalopek deleted the mergify/bp/release/v5.1.x/pr-2110 branch July 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants