We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This issue keeps track of a list of relatively small changes that need to be applied to the code:
Remove EmitEvent from CCV code, e.g.,
interchain-security/x/ccv/child/module.go
Line 337 in eccbfaa
Check counterparty port id during the channel handshake, i.e.,
interchain-security/x/ccv/parent/module.go
Line 236 in eccbfaa
Line 221 in eccbfaa
Remove hardcoded constants. For example: https://github.com/cosmos/interchain-security/blob/main/x/ccv/types/utils.go#L6
Implement one consistent scheme for key prefixes. Iota is probably best (see Variable length string prefixes could lead to injection attack #18)
Correct this bug and increment the ID in the proper place https://github.com/cosmos/interchain-security/blob/main/x/ccv/parent/keeper/relay.go#L113
Delete the child genesis once the CCV channel for the chainID is OPEN since we no longer need to store it on parent chain.
keeper.go and other large files could be broken up
The text was updated successfully, but these errors were encountered:
Close as the tasks here were split in different issues: #279, #280, #281, #282
Sorry, something went wrong.
Merge pull request #36 from informalsystems/marius/remove-vscmatured
a0fcd07
feat!: remove unbonding pausing
No branches or pull requests
This issue keeps track of a list of relatively small changes that need to be applied to the code:
Remove EmitEvent from CCV code, e.g.,
interchain-security/x/ccv/child/module.go
Line 337 in eccbfaa
Check counterparty port id during the channel handshake, i.e.,
interchain-security/x/ccv/parent/module.go
Line 236 in eccbfaa
interchain-security/x/ccv/child/module.go
Line 221 in eccbfaa
Remove hardcoded constants. For example: https://github.com/cosmos/interchain-security/blob/main/x/ccv/types/utils.go#L6
Implement one consistent scheme for key prefixes. Iota is probably best (see Variable length string prefixes could lead to injection attack #18)
Correct this bug and increment the ID in the proper place https://github.com/cosmos/interchain-security/blob/main/x/ccv/parent/keeper/relay.go#L113
Delete the child genesis once the CCV channel for the chainID is OPEN since we no longer need to store it on parent chain.
keeper.go and other large files could be broken up
The text was updated successfully, but these errors were encountered: