-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cargo protoc error #44
Conversation
@ethanfrey Hi, Can you review this PR? |
Relate Rust no-std: https://justjjy.com/Rust-no-std |
Thanks for updating this. I think you also need to bump prost version in |
#[prost(bytes, tag = "1")] | ||
pub key: alloc::vec::Vec<u8>, | ||
#[prost(bytes = "vec", tag = "1")] | ||
pub key: ::prost::alloc::vec::Vec<u8>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better. I need to test it locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better. I need to test it locally
enen, I tested it and it's OK.
Ye, I have been update cargo.toml. |
Looks good. I checked out the code and all tests pass. Running |
Fix : #43
Relate issue: #42
For
api.rs
also passes the test underno_std
is problematic, due to the use of theFile
andIO
libraries under the standard library. However, there is no core library incore
, andalloc
, so now it is possible to handle it in this way and only let it test under std.