fix: prevent out of bounds on lookup inners access #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out-of-bounds-lookup-inners
also added a unit test for decompressExist to cover new error handling
colin-axner
reviewed
Oct 8, 2024
| if exist == nil { | ||
| return nil | ||
| return nil, nil |
There was a problem hiding this comment.
tests broke with an error return here. I don't have a great understanding of when this case arises? Is there a comment we can add to elaborate on it? @AdityaSripal
There was a problem hiding this comment.
If a nonexistence proof is proving the leftmost key wouldn't the leftExist be nil? So decompressExist returns nil and we don't error out on line 149
There was a problem hiding this comment.
ah yes, thank you! That makes sense to me, added a comment
|
Is this pr still needed if we're removing batch proofs? |
Nope, changes are no longer relevant! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decompressing a compressed proof. If the compressed proof has a path value (index) which is out of bounds of the inner op lookup list, return an error (previously would panic)