Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS28: vsc will not mature if there are no updates from provider #747

Merged
merged 1 commit into from
May 20, 2022
Merged

ICS28: vsc will not mature if there are no updates from provider #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec/app/ics-028-cross-chain-validation/technical_specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,6 +1727,11 @@ function EndBlock(): [ValidatorUpdate] {
DistributeRewards()
}

// unbond mature packets if the CCV channel is established
if providerChannel != "" {
UnbondMaturePackets()
}

if pendingChanges.IsEmpty() {
// do nothing
return []
Expand All @@ -1742,11 +1747,6 @@ function EndBlock(): [ValidatorUpdate] {
// update validatorSet
UpdateValidatorSet(changes)

// unbond mature packets if the CCV channel is established
if providerChannel != "" {
UnbondMaturePackets()
}

// return the validator set updates to the consensus engine
return changes
}
Expand Down