ICS27: add support for unordered channels/implement upgrade callbacks #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
changed the title
crodriguezvega
requested review from
AdityaSripal,
cwgoes,
colin-axner and
angbrav
as code owners
AdityaSripal
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Nice work Carlos!
Additionally in a future PR, we can think about how to open an UNORDERED channel that can be used by multiple owners. THis should be possible by allowing a new ICA port without an owner address, and putting the address instead in the packet data
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It additionally...
closes #650