Skip to content

Commit

Permalink
ICS 04 (upgrades): improvements for readability and inconsistency fix…
Browse files Browse the repository at this point in the history
…es (#991)

* style, formatting, readability, inconsistency fixed

* fixes for better readability

* another fix

* split line

* fixes for upgrade sequence

* fix typos

* fix type

* formatting, consistency fixes

* use provable store

* alignment
  • Loading branch information
crodriguezvega authored Jul 28, 2023
1 parent 5a50f67 commit 0ce921d
Show file tree
Hide file tree
Showing 2 changed files with 659 additions and 557 deletions.
2 changes: 1 addition & 1 deletion spec/core/ics-004-channel-and-packet-semantics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@ function timeoutPacket(
// check that timeout height or timeout timestamp has passed on the other end
abortTransactionUnless(
(packet.timeoutHeight > 0 && proofHeight >= packet.timeoutHeight) ||
(packet.timeoutTimestamp > 0 && connection.getTimestampAtHeight(proofHeight) >= packet.timeoutTimestamp))
(packet.timeoutTimestamp > 0 && getTimestampAtHeight(connection, proofHeight) >= packet.timeoutTimestamp))

// verify we actually sent this packet, check the store
abortTransactionUnless(provableStore.get(packetCommitmentPath(packet.sourcePort, packet.sourceChannel, packet.sequence))
Expand Down
Loading

0 comments on commit 0ce921d

Please sign in to comment.