-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tmclient update header validation for v0.44.x #917
Merged
Farhad-Shabani
merged 4 commits into
release/v0.44.x
from
v0.44.x/rano/fix-tmclient-update-header-validation
Oct 12, 2023
Merged
fix: tmclient update header validation for v0.44.x #917
Farhad-Shabani
merged 4 commits into
release/v0.44.x
from
v0.44.x/rano/fix-tmclient-update-header-validation
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.44.x #917 +/- ##
===================================================
+ Coverage 71.49% 71.65% +0.15%
===================================================
Files 124 124
Lines 14960 15035 +75
===================================================
+ Hits 10696 10773 +77
+ Misses 4264 4262 -2
☔ View full report in Codecov by Sentry. |
.changelog/unreleased/bug/911-fix-header-validation-during-tmclient-update.md
Show resolved
Hide resolved
Farhad-Shabani
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @rnbguy!
Farhad-Shabani
deleted the
v0.44.x/rano/fix-tmclient-update-header-validation
branch
October 12, 2023 16:12
Farhad-Shabani
added a commit
that referenced
this pull request
Oct 12, 2023
* fix: tmclient update header validation for v0.44.x (#917) * test for tmclient update with different validator sets * fix doc lints * rm incorrect check * add changelog entry * chore: prep v0.44.2 release (#918) --------- Co-authored-by: Rano | Ranadeep <[email protected]>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* fix: tmclient update header validation for v0.44.x (#917) * test for tmclient update with different validator sets * fix doc lints * rm incorrect check * add changelog entry * chore: prep v0.44.2 release (#918) --------- Co-authored-by: Rano | Ranadeep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #911 but on v0.44.x release
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.