Improve error handling and string conversion in IBC crates. #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 72.33% 72.33% -0.01%
==========================================
Files 116 116
Lines 15529 15546 +17
==========================================
+ Hits 11233 11245 +12
- Misses 4296 4301 +5
☔ View full report in Codecov by Sentry. |
plafer
suggested changes
Jun 22, 2023
|
Can you also add a changelog entry? |
…ror messages and improve UTF-8 compliance. Update try_from convenience methods to return error messages for incorrect data ranges.
Signed-off-by: Davirain <[email protected]>
Signed-off-by: Davirain <[email protected]>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Improve error handling and string conversion in IBC crates. * Refactor crate to disallow usage of unwrap(), add more informative error messages and improve UTF-8 compliance. Update try_from convenience methods to return error messages for incorrect data ranges. * Refactor client_state.rs: Fix tests to use height.min() in expect. * Refactor host block retrieval in MockContext struct. --------- Signed-off-by: Davirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #655
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.