Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve rust-version check #1381

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

ci: improve rust-version check #1381

wants to merge 14 commits into from

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Nov 26, 2024

Closes: #1382

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.83%. Comparing base (0357976) to head (356e592).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   66.83%   66.83%           
=======================================
  Files         225      225           
  Lines       22594    22594           
=======================================
  Hits        15100    15100           
  Misses       7494     7494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy
Copy link
Collaborator Author

rnbguy commented Nov 26, 2024

build still fails as the latest tendermint-proto and scale-info pulls the latest parity-scale-codec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest builds fail with rust version
1 participant