Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl: new packet structure for eureka #1365

Open
wants to merge 5 commits into
base: rano/eureka/1367
Choose a base branch
from

refactor handler for new packet struct

416f410
Select commit
Loading
Failed to load commit list.
Open

impl: new packet structure for eureka #1365

refactor handler for new packet struct
416f410
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 29, 2024 in 0s

53.88% (-12.96%) compared to cdd4625

View this Pull Request on Codecov

53.88% (-12.96%) compared to cdd4625

Details

Codecov Report

Attention: Patch coverage is 16.71316% with 6568 lines in your changes missing coverage. Please review.

Project coverage is 53.88%. Comparing base (cdd4625) to head (416f410).

Files with missing lines Patch % Lines
...-eureka-core/ics04-channel/types/src/events/mod.rs 0.00% 684 Missing ⚠️
ibc-eureka-core/ics24-host/types/src/path.rs 0.00% 546 Missing ⚠️
ibc-eureka-core/ics04-channel/types/src/channel.rs 0.00% 330 Missing ⚠️
...reka-core/ics03-connection/types/src/connection.rs 0.00% 292 Missing ⚠️
...reka-core/ics04-channel/src/handler/recv_packet.rs 0.00% 193 Missing ⚠️
ibc-eureka-core/ics02-client/types/src/events.rs 52.83% 191 Missing ⚠️
...c-eureka-core/ics04-channel/src/handler/timeout.rs 0.00% 173 Missing ⚠️
...core/ics03-connection/src/handler/conn_open_try.rs 0.00% 146 Missing ⚠️
...c-eureka-core/ics23-commitment/types/src/merkle.rs 0.00% 146 Missing ⚠️
...core/ics03-connection/src/handler/conn_open_ack.rs 0.00% 145 Missing ⚠️
... and 78 more
Additional details and impacted files 
@@                 Coverage Diff                  @@
##           feat/ibc-eureka    #1365       +/-   ##
====================================================
- Coverage            66.84%   53.88%   -12.96%     
====================================================
  Files                  225      315       +90     
  Lines                22631    30517     +7886     
====================================================
+ Hits                 15127    16445     +1318     
- Misses                7504    14072     +6568

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov