Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: miscellaneous repository maintenance #1174

Merged
merged 29 commits into from
Apr 24, 2024
Merged

chore: miscellaneous repository maintenance #1174

merged 29 commits into from
Apr 24, 2024

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Apr 18, 2024

  • Closes RUSTSEC-2020-0168: mach is unmaintained #1172
  • Fixes broken links on markdown files.
  • Add missing changelog entry from imp(ics23): fallible conversion for ProofSpec, LeafOp, InnerSpec #1160
  • Rename makefile to Makefile.
  • Remove unnecessary nix use in cw-check.
  • Remove rokroskar/workflow-run-cleanup-action from Rust workflow over native concurrency support.
  • Setup merge_group with correct workflow status checks.
    • Disable merge_group trigger.
    • Always run important workflows on main.
    • Remove markdown link checks from main.
  • Use .yml over .yaml .yaml over .yml as workflow file extensions.
  • Use actions-rust-lang/setup-rust-toolchain.
  • Update download artifact example for Tendermint wasm client.

Setting up merge_group is a bit complicated. To auto-remove a PR from merge_group, we need to add them as status_check for merges onto main. But if a job is not executed (because of filtering of paths or trigger events), it will never be added in merge_group - because we need all status checks to be passed before merge.

The merge_group only works for a workflow something as following:

name: Status Check Jobs
on:
  pull_request:
  merge_group:
    types: [checks_requested]


jobs:
  my-job:
    if: ${{ github.event_name != 'pull_request' }}
    steps:
      run: echo "Hello World"

So the workflow is marked as successfully executed on PR, albeit it didn't run any job. When, the PR is put in merge_group, it will actually run my-job.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (ddd3f48) to head (3bf544b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   64.33%   64.33%           
=======================================
  Files         229      229           
  Lines       22083    22083           
=======================================
  Hits        14208    14208           
  Misses       7875     7875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy marked this pull request as ready for review April 19, 2024 16:35
@rnbguy rnbguy force-pushed the rano/chores branch 5 times, most recently from eaf8a53 to 6bbb619 Compare April 24, 2024 11:26
Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for making all these improvements! 🎉

@rnbguy rnbguy added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit d72fb58 Apr 24, 2024
19 checks passed
@rnbguy rnbguy deleted the rano/chores branch April 24, 2024 17:26
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* use renamed branch

* conventionalcommits-org is down

* add missing changelog entry

* rename to Makefile

* use native concurrency option

* upgrade substrate deps

* remove redundant nix use

* correct cw-check workflow file

* use yml extension over yml

* delete nix script

* rm merge group trigger and always trigger on main

* rm md link check from main

* forbid concurrent runs for cw and no-std checks

* nit

* use actions-rust-lang/setup-rust-toolchain over actions-rs/toolchain

* imp docker run

* use cosmwasm/optimizer 0.15.1

* correct mount paths

* validate checksum

* .yaml over .yml

https://yaml.org/faq.html

* install cargo binary before wasm compile to avoid docker mount permission

* fix permissions manually

* conventionalcommits.org is up

* update upload cw client action

* correct download path

* update cargo lockfiles

* redundant Swatinem/rust-cache

actions-rust-lang/setup-rust-toolchain@v1 uses it already

* update release workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0168: mach is unmaintained
2 participants