fix(ibc-client-tendermint-types): drop frozen height check in TryFrom of TmClientState
#1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farhad-Shabani
changed the title
TryFrom of TmClientState conversionTryFrom of TmClientState
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
- Coverage 67.05% 67.02% -0.04%
==========================================
Files 204 204
Lines 20552 20525 -27
==========================================
- Hits 13782 13756 -26
+ Misses 6770 6769 -1 ☔ View full report in Codecov by Sentry. |
rnbguy
approved these changes
Jan 26, 2024
7 tasks
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
…m` of `TmClientState` (#1062) * Fix issues related to frozen height of tendermint client. * fix: ease frozen height check within TryFrom for TmClientState * nit: set correct vallue for the frozen height in test * nit * use rstest cases * add check for is_frozen --------- Co-authored-by: Rivers Yang <[email protected]> Co-authored-by: Ranadeep Biswas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1061
Integration tests: informalsystems/basecoin-rs#151
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.