-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ibc): add missing dependencies for feature flags across multiple crates #1060
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
=======================================
Coverage 67.05% 67.05%
=======================================
Files 204 204
Lines 20552 20552
=======================================
Hits 13782 13782
Misses 6770 6770 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
#[cfg(feature = "serde")] | ||
impl FromStr for Ics721Data { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this interesting as this general FromStr
trait is only implemented with serde
. I would expect this to be implemented with borsh
or any other similar features - or is this necessary?
…crates (#1060) * fix: add missing dependencies for some feature flags * fix: derive serde attr on ics20 serializer imports * ease serde derive on ICS20 & ICS721 types * imp: ease serde derive on ics20 and ics721 types * nit: fix the name of v0.50.0 dir under changelog * nit
Closes: #1059
Integration tests: informalsystems/basecoin-rs#151
Remark
Along with this PR:
serde
derive on ICS-20 and ICS-721 domain typesv0.50.0
directory under the changelogPR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.