You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both types are imported from tendermint (one from the light the other from block) and both boil down to a u64. Unless there is a specific reason to keep both, we should be consistent here. Even better, maybe we can have our own definition of a Height that is (in some sense) even more general than the definitions from tendermint.
Version
Steps to Reproduce
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary of Bug
There are currently two type declarations for
Height
in the modules:https://github.com/informalsystems/ibc-rs/blob/65487863a68e6307d1b08c02f202a4ba1f2c6340/modules/src/lib.rs#L36
Height
being used in each specific module is different, for example:https://github.com/informalsystems/ibc-rs/blob/c447e63692c663a6af325196e8f92cf9a32bf91d/modules/src/ics03_connection/events.rs#L11-L14
Both types are imported from tendermint (one from the
light
the other fromblock
) and both boil down to au64
. Unless there is a specific reason to keep both, we should be consistent here. Even better, maybe we can have our own definition of aHeight
that is (in some sense) even more general than the definitions from tendermint.Version
Steps to Reproduce
For Admin Use
The text was updated successfully, but these errors were encountered: