Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tonic 0.9 and automatically patch the generated protos #78

Merged
merged 11 commits into from
Apr 11, 2023

Conversation

romac
Copy link
Member

@romac romac commented Apr 11, 2023

Closes: #2
Closes: #69
Closes: #79

@romac romac force-pushed the romac/regenerate-protos branch from 7aaf16e to f7ea34a Compare April 11, 2023 14:20
@romac romac marked this pull request as ready for review April 11, 2023 14:21
Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@romac romac merged commit 64fdc7f into main Apr 11, 2023
@romac romac deleted the romac/regenerate-protos branch April 11, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to tonic 0.9 Compiling protos fails when following instructions Automate patching of proto files
2 participants