Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename portid and port prefix for interchain accounts submodules #779

Merged
merged 5 commits into from
Feb 2, 2022
Merged

rename portid and port prefix for interchain accounts submodules #779

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd66668
rename portid and port prefix for interchain accounts submodules
crodriguezvega Jan 21, 2022
c00b0e1
Merge branch 'main' into carlos/778-rename-portid-and-portprefix
Jan 21, 2022
7a361b9
Merge branch 'main' into carlos/778-rename-portid-and-portprefix
colin-axner Jan 31, 2022
9af0898
Merge branch 'main' into carlos/778-rename-portid-and-portprefix
colin-axner Feb 2, 2022
767b24b
Merge branch 'main' into carlos/778-rename-portid-and-portprefix
mergify[bot] Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/apps/27-interchain-accounts/types/keys.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ const (
ModuleName = "interchainaccounts"

// PortID is the default port id that the interchain accounts host submodule binds to
PortID = "interchain-account"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damiannolan I think this will break compatibility with 0.9.0 hermes relayer, right? It's hardcoded to use interchain-account.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out with hermes v0.9.0 and everything is working as expected. New controller port prefix in logs shows as below and account registers successfully:

2022-01-21T12:58:22.599864Z  INFO ThreadId(46) [test-1:icacontroller-cosmos1m9l358xunhhwds0568za49mzhvuxx9uxre5tud/channel-0 -> test-2] finished scheduling pending packets clearing height=Some(Height { revision: 1, height: 61 })

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hermes v0.10.0 you’ll see modules/applications/mod.rs which has a hardcoded prefix, but its not there on v0.9.0, neither is the custom version negotiation from relayer/channel/version.rs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Thanks a lot, @damiannolan, for already testing this!

PortID = "icahost"

// PortPrefix is the default port prefix that the interchain accounts controller submodule binds to
PortPrefix = "ics27-"
PortPrefix = "icacontroller-"

// Version defines the current version for interchain accounts
Version = "ics27-1"
Expand Down