Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump wasmvm to v2.1.4 #7735

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Conversation

gjermundgaraba
Copy link
Contributor

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor

this point by damian should still stand no? #7324 (comment) (going to close previous pr)

@damiannolan
Copy link
Member

this point by damian should still stand no? #7324 (comment) (going to close previous pr)

Yeah, sounds about right! 👍🏻

When back porting a new branch should be created for 08-wasm and bump the minor version. Make it very clear in release notes that it is consensus breaking.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

You can retroactively add a branch and new label to let mergify do its business

@gjermundgaraba gjermundgaraba merged commit 23a4a96 into main Dec 20, 2024
65 of 66 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/bump-wasmvm branch December 20, 2024 09:38
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit 23a4a96)

# Conflicts:
#	modules/light-clients/08-wasm/go.mod
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit 23a4a96)

# Conflicts:
#	modules/light-clients/08-wasm/go.mod
gjermundgaraba added a commit that referenced this pull request Dec 20, 2024
* chore: bump wasmvm (#7735)

Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit 23a4a96)

# Conflicts:
#	modules/light-clients/08-wasm/go.mod

* Fix merge conflict

---------

Co-authored-by: Gjermund Garaba <[email protected]>
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit 23a4a96)

# Conflicts:
#	modules/light-clients/08-wasm/go.mod
#	modules/light-clients/08-wasm/go.sum
gjermundgaraba added a commit that referenced this pull request Dec 20, 2024
* chore: bump wasmvm (#7735)

Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit 23a4a96)

# Conflicts:
#	modules/light-clients/08-wasm/go.mod
#	modules/light-clients/08-wasm/go.sum

* fix conflict

---------

Co-authored-by: Gjermund Garaba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants