Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: accidental change of consensus height to pointer #7130

Merged
merged 2 commits into from
Aug 13, 2024
Merged

revert: accidental change of consensus height to pointer #7130

merged 2 commits into from
Aug 13, 2024

Conversation

colin-axner
Copy link
Contributor

Description

I noticed an unintentional change of the consensus height to a pointer in #6937

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@colin-axner colin-axner added priority PRs that need prompt reviews backport-to-v9.0.x labels Aug 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
48 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@colin-axner colin-axner added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit e69c8f3 Aug 13, 2024
69 of 70 checks passed
@colin-axner colin-axner deleted the colin/revert-accidental-change branch August 13, 2024 09:24
mergify bot pushed a commit that referenced this pull request Aug 13, 2024
@colin-axner @mergify
revert: accidental change of consensus height to pointer (#7130)
ad8e4f5 
(cherry picked from commit e69c8f3)
@mergify mergify bot mentioned this pull request Aug 13, 2024
Merged
10 tasks
chatton pushed a commit that referenced this pull request Aug 14, 2024
@mergify @colin-axner @damiannolan
revert: accidental change of consensus height to pointer (#7130) (#7145)
54b6e5f 
(cherry picked from commit e69c8f3)

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
backport-to-v9.0.x priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-axner @damiannolan @crodriguezvega