refactor!: remove 24-host path function in favour of sybling key functions #7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Aug 1, 2024
colin-axner
commented
Aug 1, 2024
| @@ -1,21 +1,46 @@ | |||
| package host | |||
|
|
|||
| import "fmt" | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
full copy/paste from _path.go
colin-axner
commented
Aug 1, 2024
|
|
||
| // ChannelCapabilityPath defines the path under which capability keys associated | ||
| // with a channel are stored | ||
| func ChannelCapabilityPath(portID, channelID string) string { |
There was a problem hiding this comment.
ported over, will be removed in v10
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
damiannolan,
chatton,
DimitrisJim,
srdtrk,
gjermundgaraba and
bznein
as code owners
…colin/6882-host-path
|
DimitrisJim
approved these changes
Aug 1, 2024
gjermundgaraba
approved these changes
Aug 1, 2024
Merged
10 tasks
DimitrisJim
added a commit
that referenced
this pull request
Aug 5, 2024
…tions (backport #7016) (#7034) * refactor!: remove 24-host path function in favour of sybling key functions (#7016) * refactor: remove all Path functions from 24-host in favour of Key functions * docs: migration + changelog * Update docs/docs/05-migrations/13-v8-to-v9.md * lint (cherry picked from commit f4eba71) # Conflicts: # CHANGELOG.md # docs/docs/05-migrations/13-v8-to-v9.md * chore: fix CHANGELOG conflict, completely remove docs folder. * nit: remove linkcheck workflow. --------- Co-authored-by: colin axnér <[email protected]> Co-authored-by: DimitrisJim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6882
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.