Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): return client identifier in create client response. #6886

Merged
merged 2 commits into from
Jul 19, 2024
Merged

feat(core): return client identifier in create client response. #6886

merged 2 commits into from
Jul 19, 2024

Conversation

DimitrisJim
Copy link
Contributor

Description

surfaced during alpha audit of v9.

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

crodriguezvega
crodriguezvega approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

damiannolan
damiannolan approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slam!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DimitrisJim DimitrisJim added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit aefc31d Jul 19, 2024
67 of 69 checks passed
@DimitrisJim DimitrisJim deleted the jim/create-client-resp-client-id branch July 19, 2024 10:56
mergify bot pushed a commit that referenced this pull request Jul 19, 2024
@DimitrisJim @mergify
feat(core): return client identifier in create client response. (#6886)
81b93ca 
(cherry picked from commit aefc31d)
@mergify mergify bot mentioned this pull request Jul 19, 2024
Merged
10 tasks
crodriguezvega pushed a commit that referenced this pull request Jul 21, 2024
@mergify @DimitrisJim
feat(core): return client identifier in create client response. (#6886)…
d1675fd 
… (#6903)

(cherry picked from commit aefc31d)

Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
backport-to-v9.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitrisJim @damiannolan @crodriguezvega