Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: add channel ordering to write acknowledgement event #6867

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #6865


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega changed the title docs: remove ordering from write ack event and non-hex data atrributes events: add channel ordering to write acknowledgement event Jul 17, 2024
Copy link

@DimitrisJim DimitrisJim added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 352ba6e Jul 18, 2024
67 of 69 checks passed
@DimitrisJim DimitrisJim deleted the carlos/6865-write_acknowledgement-event-doesnt-contain-channel-ordering branch July 18, 2024 09:03
mergify bot pushed a commit that referenced this pull request Jul 18, 2024
* docs: remove ordering from write ack event and non-hex data atrributes

* rever doc changes

* add ordering to write acknowledgement event

* Update events.md

(cherry picked from commit 352ba6e)
mergify bot pushed a commit that referenced this pull request Jul 18, 2024
* docs: remove ordering from write ack event and non-hex data atrributes

* rever doc changes

* add ordering to write acknowledgement event

* Update events.md

(cherry picked from commit 352ba6e)
crodriguezvega pushed a commit that referenced this pull request Jul 18, 2024
…6871)

* docs: remove ordering from write ack event and non-hex data atrributes

* rever doc changes

* add ordering to write acknowledgement event

* Update events.md

(cherry picked from commit 352ba6e)

Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega pushed a commit that referenced this pull request Jul 18, 2024
…6872)

* docs: remove ordering from write ack event and non-hex data atrributes

* rever doc changes

* add ordering to write acknowledgement event

* Update events.md

(cherry picked from commit 352ba6e)

Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_acknowledgement event doesn't contain channel ordering
3 participants