Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump module path to v9 #6820

Merged
merged 2 commits into from
Jul 17, 2024
Merged

chore: bump module path to v9 #6820

merged 2 commits into from
Jul 17, 2024

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Jul 15, 2024

Description

closes: #6593


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor Author

going to do an additional commit for .md files based on find . -type f -name '*.md' | xargs sed -i 's/ibc-go\/v8/ibc-go\/v9/g' and dropping changes in versioned_docs.

if anyone knows of addtional spots to changes things (did *.go, *.proto, *.md) lmk!

@DimitrisJim DimitrisJim added the priority PRs that need prompt reviews label Jul 17, 2024
@@ -4,7 +4,11 @@ go 1.22.2

toolchain go1.22.3

replace github.com/strangelove-ventures/interchaintest/v8 => github.com/DimitrisJim/interchaintest/v8 v8.0.0-20240419095404-2c9270423b9a
// needed temporarily for v9.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

butchered interchaintest to remove wasmd references for time being. for the rpc client, I forked and bumped to v9. Wasn't seeing the removals for its references (wasmd was mainly in tests) as quicker to get things running.

Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @DimitrisJim! Happy to rely on ci here. Is there any notable changes other than what you've flagged for e2e?

@DimitrisJim
Copy link
Contributor Author

Is there any notable changes other than what you've flagged for e2e?

Nope! Apart from butchering interchaintest and tweaking the other dep, all other steps were basically a find . -type f -name '*.<file_type>' | xargs sed -i 's/ibc-go\/v8/ibc-go\/v9/g'.

Also placed trust in CI to flag any places other than imports where that bulk replace could've messed things up.

@DimitrisJim
Copy link
Contributor Author

Going off, if anyone reviews and approves (or adds something I've missed) feel free to merge afterwards!

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you thank you thank youu!!! ❤️

Copy link

@damiannolan damiannolan added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 5d76556 Jul 17, 2024
158 checks passed
@damiannolan damiannolan deleted the jim/bump-to-v9 branch July 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump package to v9
4 participants