-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump module path to v9 #6820
Conversation
295b9f4
to
e34a1d2
Compare
going to do an additional commit for if anyone knows of addtional spots to changes things (did |
e34a1d2
to
e6f18b8
Compare
@@ -4,7 +4,11 @@ go 1.22.2 | |||
|
|||
toolchain go1.22.3 | |||
|
|||
replace github.com/strangelove-ventures/interchaintest/v8 => github.com/DimitrisJim/interchaintest/v8 v8.0.0-20240419095404-2c9270423b9a | |||
// needed temporarily for v9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
butchered interchaintest to remove wasmd
references for time being. for the rpc client, I forked and bumped to v9. Wasn't seeing the removals for its references (wasmd was mainly in tests) as quicker to get things running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up @DimitrisJim! Happy to rely on ci here. Is there any notable changes other than what you've flagged for e2e?
Nope! Apart from butchering interchaintest and tweaking the other dep, all other steps were basically a Also placed trust in CI to flag any places other than imports where that bulk replace could've messed things up. |
Going off, if anyone reviews and approves (or adds something I've missed) feel free to merge afterwards! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you thank you thank youu!!! ❤️
|
Description
closes: #6593
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.