ci: update workflow fork conditions to allow run on copies #6783
Conversation
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
chatton,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
|
This PR is a test. Don't merge! edit: It looks like this may be good to go! 🚀 |
|
It appears that updating the 
The changes in this repo allows the e2e-fork workflow to run on both forks and copies of the repository. Specifically, if we're running on |
damiannolan
changed the title
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' }} | ||
|
|
||
| jobs: | ||
| # dynamically build a matrix of test/test suite pairs to run | ||
| build-test-matrix: | ||
| if: ${{ github.event.pull_request.head.repo.fork || github.actor == 'dependabot[bot]' || github.event_name == 'workflow_dispatch' }} | ||
| if: ${{ github.repository != 'cosmos/ibc-go' || github.actor == 'dependabot[bot]' || github.event_name == 'workflow_dispatch' }} |
There was a problem hiding this comment.
fine with either but is this required? I'd assume checking if it is/isn't a fork was the most general option?
There was a problem hiding this comment.
Yeah, pretty much! It's a cute solution I think. With Github forks, they can't be private, you don't have the ability to change the visibility.
So to use something like a "private fork", it is not treated as an actual fork, and more like importing a particular git history into a new repository.
There was a problem hiding this comment.
to use something like a "private fork", it is not treated as an actual fork
quirky af. Makes sense to me, want to add a small comment there explaining it? Can see this as being something someone would change in future w/o knowing why it was there.
| @@ -11,13 +11,13 @@ on: | |||
|
|
|||
| # cancel workflows if a new one is triggered on the same branch. | |||
| concurrency: | |||
| group: ${{ github.ref }} | |||
| group: ${{ github.workflow }}-${{ github.ref }} | |||
There was a problem hiding this comment.
do we want to amend similar line in e2e-wasm?
Description
Updates E2E fork conditions to allow
e2e-forkto also run on copies.See: https://github.com/damiannolan/ibc-go-test/pull/9
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.