Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(test) - Three chains path forwarding with unwind #6778

Merged
merged 13 commits into from
Jul 9, 2024
Merged

(test) - Three chains path forwarding with unwind #6778

merged 13 commits into from
Jul 9, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Jul 8, 2024

Description

ref: #6578

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@bznein bznein added the priority PRs that need prompt reviews label Jul 8, 2024
crodriguezvega
crodriguezvega approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test, easy to read. All the infrastructure magic happening underneath to set up the chains, channels and relayers really pays off to make the test really easy to follow.

e2e/tests/transfer/forwarding_test.go Show resolved Hide resolved
@bznein bznein changed the title (test) - Three chains path forwaring with unwind (test) - Three chains path forwarding with unwind Jul 8, 2024
@bznein bznein mentioned this pull request Jul 9, 2024
Closed
DimitrisJim
DimitrisJim approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautifully written! echo Carlos's comment re readability. Lgtm, thanks @bznein!

e2e/tests/transfer/forwarding_test.go Show resolved Hide resolved
e2e/tests/transfer/forwarding_test.go Show resolved Hide resolved
gjermundgaraba
gjermundgaraba approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, these tests are getting so much easier to read now <3

@bznein bznein added this pull request to the merge queue Jul 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2024
@bznein @DimitrisJim
(test) - Three chains path forwarding with unwind (#6778)
1479049 
* Unwind test

* Docstring and simplified logic.

* Fixed parameter

* linter

* Add check for packet relayed.

* Fix chain

* Update e2e/tests/transfer/forwarding_test.go

Co-authored-by: DimitrisJim <[email protected]>

---------

Co-authored-by: DimitrisJim <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
68.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@bznein bznein added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 3370cdf Jul 9, 2024
76 of 77 checks passed
@bznein bznein deleted the bznein/6578/test2 branch July 9, 2024 10:12
@crodriguezvega crodriguezvega mentioned this pull request Jul 10, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bznein @gjermundgaraba @crodriguezvega @DimitrisJim