Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core/02-client): remove the legacy handler for 02-client. #6777

Merged
merged 9 commits into from
Jul 9, 2024
Merged

chore(core/02-client): remove the legacy handler for 02-client. #6777

merged 9 commits into from
Jul 9, 2024

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Jul 8, 2024 •
edited
Loading

Description

will remove msgs in other PR. Going to add to migration docs after open.

closes: #5666

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor Author

issue #5666 and PR #6777, nice

@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Jul 8, 2024
crodriguezvega
crodriguezvega approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @DimitrisJim!

docs/docs/05-migrations/13-v8-to-v9.md Outdated Show resolved Hide resolved
bznein
bznein approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@bznein bznein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love PRs with a lot of red!

@crodriguezvega
Copy link
Contributor

Love PRs with a lot of red!

🔴 is the new 🟢!

gjermundgaraba
gjermundgaraba approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get this cleaned up <3

@DimitrisJim DimitrisJim enabled auto-merge July 9, 2024 09:28
@DimitrisJim DimitrisJim disabled auto-merge July 9, 2024 09:30
chatton
chatton approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The red is a thing of beauty 💪

@DimitrisJim DimitrisJim enabled auto-merge July 9, 2024 10:12
@DimitrisJim DimitrisJim added this pull request to the merge queue Jul 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
68.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Merged via the queue into main with commit 5b004f5 Jul 9, 2024
75 of 78 checks passed
@DimitrisJim DimitrisJim deleted the jim/5666-remove-legacy-gov-handlers branch July 9, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bznein bznein bznein approved these changes

@chatton chatton chatton approved these changes

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove legacy governance v1beta1 handler for ClientUpdateProposal
5 participants
@DimitrisJim @crodriguezvega @gjermundgaraba @chatton @bznein