refactor: remove unnecessary exported.Proof interface type

[colin-axner]

Description

29 lines of code that aren't needed 😄

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against the correct branch (see CONTRIBUTING.md).
• Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/).
• Added relevant godoc comments.
• Provide a conventional commit message to follow the repository standards.
• Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
• Re-reviewed Files changed in the GitHub PR explorer.
• Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

• Refactor
  • Streamlined the codebase by removing the deprecated Proof interface and its implementation MerkleProof.
  • Eliminated unnecessary imports and methods related to the Proof interface in the commitment.go file.

[coderabbitai]

Walkthrough

The recent changes involve the removal of the Proof interface and its associated methods, the MerkleProof implementation, and their registrations within the IBC core commitment module. These modifications impact the codec registration, type assertions, and corresponding test cases, simplifying the codebase by eliminating these components.

Changes

Files	Change Summary
modules/core/23-commitment/types/codec.go, modules/core/23-commitment/types/codec_test.go	Removed registration of ibc.core.commitment.v1.Proof interface, MerkleProof implementation, and related test case.
modules/core/23-commitment/types/merkle.go	Removed _ exported.Proof = (*MerkleProof)(nil) declaration.
modules/core/exported/commitment.go	Removed Proof interface, its methods, and import of github.com/cosmos/ics23/go.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0923e49 and 78fc0bf.

Files selected for processing (4)

• modules/core/23-commitment/types/codec.go (2 hunks)
• modules/core/23-commitment/types/codec_test.go (1 hunks)
• modules/core/23-commitment/types/merkle.go (1 hunks)
• modules/core/exported/commitment.go (2 hunks)

Files skipped from review due to trivial changes (4)

• modules/core/23-commitment/types/codec.go
• modules/core/23-commitment/types/codec_test.go
• modules/core/23-commitment/types/merkle.go
• modules/core/exported/commitment.go

[coderabbitai]

Actionable comments posted: 2

Out of diff range and nitpick comments (2)

CHANGELOG.md (2)

Line range hint 176-176: Format the bare URL as a proper link.

- The IBC module was removed in the commit hash [da064e13d56add466548135739c5860a9f7ed842](https://github.com/cosmos/cosmos-sdk/commit/da064e13d56add466548135739c5860a9f7ed842) on the SDK.
+ The IBC module was removed in the commit hash [da064e13d56add466548135739c5860a9f7ed842](https://github.com/cosmos/cosmos-sdk/commit/da064e13d56add466548135739c5860a9f7ed842) on the SDK.

---

Line range hint 191-191: Remove trailing spaces.

- Backports should be made to the [release/v0.42.x](https://github.com/cosmos/cosmos-sdk/tree/release/v0.42.x) branch on the SDK. 
+ Backports should be made to the [release/v0.42.x](https://github.com/cosmos/cosmos-sdk/tree/release/v0.42.x) branch on the SDK.

Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 78fc0bf and c780aac.

Files selected for processing (2)

• CHANGELOG.md (1 hunks)
• docs/docs/05-migrations/13-v8-to-v9.md (1 hunks)

Additional Context Used

Path-based Instructions (2)

docs/docs/05-migrations/13-v8-to-v9.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c780aac and 6fca9af.

Files selected for processing (1)

• CHANGELOG.md (1 hunks)

Additional Context Used

Path-based Instructions (1)

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

[damiannolan]

👍🏻

[colin-axner]

Thanks for adding the changelog and migration docs @crodriguezvega 👍

[sonarqubecloud]

Quality Gate passed for 'ibc-go'

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud