-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: add version to tm headers in ibctesting (release/v6.3.x) #6179
imp: add version to tm headers in ibctesting (release/v6.3.x) #6179
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Noting here that I'm not sure that this is needed given that v6 is an EOL release line. Feel free to close if you think, cc. @crodriguezvega |
Would we release v6.3.1 with this? Or is it out of scope since v6 is EOL? Note #6099 is now stale. https://github.com/celestiaorg/celestia-app/blob/main/go.mod#L18 @rootulp @ninabarbakadze do you have plans to go to ibc-go/v7 at some point? I'm assuming that its probably blocking due to sdk forks etc in celestia, and I think I may have been told that you might plan to go directly to v0.50+ (ibc-go/v8) or something along these lines. |
You're spot on that celestia-app is currently blocked on upgrading ibc-go because we maintain a Cosmos SDK fork that is currently on v0.46.x. We don't have firm plans but I think we'll try to bump to Cosmos SDK v0.50+ and upgrade directly to ibc-go/v8 after our next hard-fork. |
Hey @rootulp! I wanted to quickly discuss this with the team before merging since v6 is EOL. |
Awesome, thanks Damian! A v6.3.1 tag will be super helpful for us :) |
Description
Take changes forward from: #6099
This PR targets release/v6.3.x.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.