Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump wasmvm v2.0.0 (backport #5909) #6020

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 19, 2024

Description

I will mark the PR as r4r when we can use the final v2.0.0 release (using v2.0.0-rc.2 at the moment).

closes: #5283

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

  • New Features

    • Enhanced support for multiple capabilities in light clients, moving from a singular to multiple capabilities support.
    • Introduced a new gas limit parameter and additional gas-related values for improved gas management in smart contracts.
    • Randomized data directory paths for testing, ensuring unique environments for each test run.
  • Improvements

    • Updated wasmvm and wasmvmtypes dependencies to version 2 across various modules for better performance and compatibility.
    • Refined gas cost constants and introduced a new WasmGasRegisterConfig struct for more flexible gas cost configuration.
    • Improved type safety and error handling by updating function return types to use ContractResult and QueryResult.
  • Documentation

    • Updated the CHANGELOG to reflect the dependency update to wasmvm version 2.0.0.
  • Bug Fixes

    • Addressed various minor bugs related to import paths and function signatures to align with the new wasmvm version 2 updates.

This is an automatic backport of pull request #5909 done by [Mergify](https://mergify.com).

* deps: bump wasmvm v2.0.0

* indentation

* remove empty lines

* linter

* more linting

* add test and fix test

* append random string to data directory + address review comments

* added comment about random string added to data dir

* fix typo

* code ID -> checksum

* deps: bump wasmvm v2.0.0

* add changelog

* address review comment and fix merge conflicts

* fix broken link

* linter

* address review comment

---------

Co-authored-by: DimitrisJim <[email protected]>
(cherry picked from commit 30d56fc)

# Conflicts:
#	docs/docs/03-light-clients/04-wasm/03-integration.md
#	docs/docs/03-light-clients/04-wasm/09-migrations.md
#	e2e/go.mod
#	e2e/go.sum
#	modules/light-clients/08-wasm/CHANGELOG.md
#	modules/light-clients/08-wasm/go.mod
#	modules/light-clients/08-wasm/go.sum
#	modules/light-clients/08-wasm/light_client_module_test.go
#	modules/light-clients/08-wasm/testing/simapp/app.go
#	modules/light-clients/08-wasm/wasm_test.go
Copy link
Contributor Author

mergify bot commented Mar 19, 2024

Cherry-pick of 30d56fc has failed:

On branch mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x/pr-5909
Your branch is up to date with 'origin/08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x'.

You are currently cherry-picking commit 30d56fc8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/light-clients/08-wasm/internal/ibcwasm/expected_interfaces.go
	modified:   modules/light-clients/08-wasm/keeper/genesis.go
	modified:   modules/light-clients/08-wasm/keeper/keeper.go
	modified:   modules/light-clients/08-wasm/keeper/keeper_test.go
	modified:   modules/light-clients/08-wasm/keeper/msg_server_test.go
	modified:   modules/light-clients/08-wasm/keeper/options_test.go
	modified:   modules/light-clients/08-wasm/testing/mock_engine.go
	modified:   modules/light-clients/08-wasm/testing/simapp/simd/cmd/root.go
	modified:   modules/light-clients/08-wasm/types/client_state_test.go
	modified:   modules/light-clients/08-wasm/types/config.go
	modified:   modules/light-clients/08-wasm/types/errors.go
	modified:   modules/light-clients/08-wasm/types/gas_register.go
	modified:   modules/light-clients/08-wasm/types/gas_register_custom.go
	modified:   modules/light-clients/08-wasm/types/migrate_contract_test.go
	modified:   modules/light-clients/08-wasm/types/misbehaviour_handle_test.go
	modified:   modules/light-clients/08-wasm/types/proposal_handle_test.go
	modified:   modules/light-clients/08-wasm/types/querier.go
	modified:   modules/light-clients/08-wasm/types/querier_test.go
	modified:   modules/light-clients/08-wasm/types/store.go
	modified:   modules/light-clients/08-wasm/types/types_test.go
	modified:   modules/light-clients/08-wasm/types/update_test.go
	modified:   modules/light-clients/08-wasm/types/upgrade_test.go
	modified:   modules/light-clients/08-wasm/types/vm.go
	modified:   modules/light-clients/08-wasm/types/vm_test.go
	modified:   scripts/get-libwasm-version.py

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   docs/docs/03-light-clients/04-wasm/03-integration.md
	deleted by us:   docs/docs/03-light-clients/04-wasm/09-migrations.md
	deleted by us:   e2e/go.mod
	deleted by us:   e2e/go.sum
	both modified:   modules/light-clients/08-wasm/CHANGELOG.md
	both modified:   modules/light-clients/08-wasm/go.mod
	both modified:   modules/light-clients/08-wasm/go.sum
	deleted by us:   modules/light-clients/08-wasm/light_client_module_test.go
	both modified:   modules/light-clients/08-wasm/testing/simapp/app.go
	deleted by us:   modules/light-clients/08-wasm/wasm_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

coderabbitai bot commented Mar 19, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@crodriguezvega crodriguezvega removed their assignment Mar 19, 2024
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, left a couple of small qs.

e2e/go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

modules/light-clients/08-wasm/go.mod Show resolved Hide resolved
@crodriguezvega crodriguezvega merged commit 5cd3b43 into 08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x Mar 20, 2024
22 checks passed
@crodriguezvega crodriguezvega deleted the mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x/pr-5909 branch March 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants