Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: deny selected client types from VerifyMembership rpc (backport #5871) #5885

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 21, 2024

This is an automatic backport of pull request #5871 done by Mergify.
Cherry-pick of 4f14cfd has failed:

On branch mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x/pr-5871
Your branch is up to date with 'origin/08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x'.

You are currently cherry-picking commit 4f14cfd8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   modules/core/02-client/keeper/grpc_query.go
	both modified:   modules/core/02-client/keeper/grpc_query_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* chore: add client status check to verify membership rpc

* imp: deny selected client types from VerifyMembership rpc

(cherry picked from commit 4f14cfd)

# Conflicts:
#	modules/core/02-client/keeper/grpc_query.go
#	modules/core/02-client/keeper/grpc_query_test.go
@crodriguezvega crodriguezvega self-assigned this Feb 21, 2024
Carlos Rodriguez added 2 commits February 21, 2024 22:38
…o mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x/pr-5871

# Conflicts:
#	modules/core/02-client/keeper/grpc_query.go
#	modules/core/02-client/keeper/grpc_query_test.go
@DimitrisJim
Copy link
Contributor

q: do we backport action for running 08-wasm tests to this branch? It could be overkill but might be nice to have it running here too.

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Feb 23, 2024

q: do we backport action for running 08-wasm tests to this branch? It could be overkill but might be nice to have it running here too.

Sounds like a good idea. I can look into it next week.

@crodriguezvega crodriguezvega merged commit 9048012 into 08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x Feb 23, 2024
17 checks passed
@crodriguezvega crodriguezvega deleted the mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.2.x-wasmvm-v2.0.x/pr-5871 branch February 23, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants