Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(fee): capital efficient fee middleware (backport #5571) #5634

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 17, 2024

This is an automatic backport of pull request #5571 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* feat: initial implementation

* test: fixed keeper tests

* test: fixed types tests

* test: all tests passing

* test: fixed fee callbacks test

* feat: implemented migration

* test: added migration tests

* docs: updated godocs

* imp: review items

* imp: review items

* imp: review items

* docs: updated godocs

* test: added multiple denoms test case for total

* specify what the migration that fails does in error message

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
(cherry picked from commit 6fc8159)
Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. No conflicts :)

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@srdtrk srdtrk merged commit 8fd727c into release/v8.1.x Jan 17, 2024
19 checks passed
@srdtrk srdtrk deleted the mergify/bp/release/v8.1.x/pr-5571 branch January 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants