e2e(upgrades): crossing hello test #5535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llo-scenario # Conflicts: # e2e/tests/core/04-channel/upgrades_test.go
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
charleenfei,
damiannolan,
chatton and
DimitrisJim
as code owners
colin-axner
reviewed
Jan 30, 2024
Comment on lines
+264
to
+267
| t.Run("start relayer", func(t *testing.T) { | ||
| s.StartRelayer(relayer) | ||
| }) | ||
|
|
There was a problem hiding this comment.
should this be after initializing upgrades on each end? Wondering if the relayer will pickup the first upgrade attempt and try on the counterparty before the counterparty submits its upgrade attempt
There was a problem hiding this comment.
that makes sense to me
There was a problem hiding this comment.
I will leave it for now like this (just want to finally merge this PR), but I will look if it makes any difference starting the relayer afterwards.
colin-axner
approved these changes
Jan 30, 2024
| s.Require().Equal(true, feeEnabled) | ||
| }) | ||
|
|
||
| t.Run("verify channel A upgraded and is fee enabled", func(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| t.Run("verify channel A upgraded and is fee enabled", func(t *testing.T) { | |
| t.Run("verify channel B upgraded and is fee enabled", func(t *testing.T) { |
damiannolan
approved these changes
Jan 30, 2024
| }) | ||
|
|
||
| t.Run("execute gov proposals to initiate channel upgrade on chain A and chain B", func(t *testing.T) { | ||
| var wg sync.WaitGroup |
There was a problem hiding this comment.
Love me a WaitGroup <3
Comment on lines
+264
to
+267
| t.Run("start relayer", func(t *testing.T) { | ||
| s.StartRelayer(relayer) | ||
| }) | ||
|
|
There was a problem hiding this comment.
that makes sense to me
crodriguezvega
deleted the
carlos/5393-successful-test-with-crossing-hello-scenario
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5393
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.