Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(statemachine)!: add check for length of version and counterparty version in channel handshake messages #4877

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Oct 16, 2023

Description

ref: #4859

I think the check for MsgChannelOpenTry and MsgChannelOpenAck might not be strictly needed, since you need a valid MsgChannelOpenInit to succeed to start the process and both messages require proofs (i.e. you could submit MsgChannelOpenTry or MsgChannelOpenAck with a version string above the maximum permitted length, but execution would fail because there wouldn't be a channel end on the counterparty with such version string), but I guess it doesn't hurt to add the check in those messages too.

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@@ -7,6 +7,8 @@ import (
"github.com/cosmos/ibc-go/v8/modules/core/exported"
)

const MaximumVersionLength = 8192 // maximum length of the version in bytes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a ballpark figure yea? We have no information on the typical length of versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a ballpark figure. Typically the version strings have been short so far, like ics20-1 or {"fee_version":"ics29-1", "app_version":"ics20-1"}, at least for our use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants