fix: allow value with slashes in URL template (for v4)

[JoowonYun]

Description

This is an issue that has already been raised and has been implemented in v7 and main. #3045
This should also apply to v5 and v6, which are currently maintained, including v4.

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

[charleenfei]

thanks for this PR @JoowonYun! I will add the backport label.

[crodriguezvega]

Thanks, @JoowonYun. Considering that all lines of v4 and v5 will reach end of line at the end of October (see here), I question if it really makes a lot of sense to backport this fix to those lines? Have you encountered situations where this problem impeded you in chains using ibc-go < v7 and you couldn't work around the problem?

[charleenfei]

i actually think we might need to look into this more, finding this issue. it looks like this fix actually has a bug which the endpoint interprets an empty trace rather than a call to the DenomTraces endpoint. we have a fix, but it's definitely worth understanding what your thoughts are on @crodriguezvega's questions above, as to backporting the fix :)

[JoowonYun]

@charleenfei Uhm.. now that I think about it, there must be a problem with DenomTraces. Actually, I was trying to fix a bug in /ibc/apps/transfer/v1/denom_hashes. Many DApps use this endpoint to find the ibc hash.

@crodriguezvega Will support for v4.5.x end in October? In that case, I will have to hardfork and manage it separately. 😢

[crodriguezvega]

@JoowonYun I think the problem with /ibc/apps/transfer/v1/denom_traces that you may be having was fixed in #4709.

If this is causing you troubles and you cannot work around the issue, we are happy to backport both #3045 and #4709 to all currently supported release lines, we just wanted to make sure that we would cut all these releases for a good reason. :)

[JoowonYun]

Ah.. I didn't understand the backport process exactly. I checked the prs and it's perfect. 👍

[crodriguezvega]

@JoowonYun The v4.5.1 release with the fix is out now.